Skip to content

Fix WebDriverWrapper.isTextPresent usages#2618

Merged
labkey-tchad merged 3 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_isHtmlPresent
Aug 13, 2025
Merged

Fix WebDriverWrapper.isTextPresent usages#2618
labkey-tchad merged 3 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_isHtmlPresent

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Aug 11, 2025

Rationale

WebDriverWrapper.isTextPresent no longer html encodes the text that is being searched for.

java.lang.AssertionError: Expected response 'This is a response to This is a real message 1754798280718 by user <a href="mailto:moderatorreviewapprovedauthor@messages.test" rel="nofollow">moderatorreviewapprovedauthor@messages.test</a>' was not present on the thread page.
  at org.junit.Assert.fail(Assert.java:89)
  at org.labkey.test.util.DeferredErrorCollector.lambda$13(DeferredErrorCollector.java:354)
  at org.labkey.test.util.DeferredErrorCollector.wrapAssertion(DeferredErrorCollector.java:187)
  at org.labkey.test.util.DeferredErrorCollector.error(DeferredErrorCollector.java:354)
  at org.labkey.test.tests.announcements.ModeratorReviewTest.addResponse(ModeratorReviewTest.java:169)
  at org.labkey.test.tests.announcements.ModeratorReviewTest.testNewThread(ModeratorReviewTest.java:134)

Introducing a separate isHtmlPresent method for cases that do want to search for HTML.

Related Pull Requests

Changes

  • Introduce WebDriverWrapper.isHtmlPresent
  • Move some basic search functionality into TextSearcher

@labkey-tchad labkey-tchad merged commit 7c88338 into release25.7-SNAPSHOT Aug 13, 2025
8 checks passed
@labkey-tchad labkey-tchad deleted the 25.7_fb_isHtmlPresent branch August 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-danield labkey-danield labkey-danield approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@labkey-tchad @labkey-danield